Skip to content

Conversation

@dconeybe
Copy link
Contributor

@dconeybe dconeybe commented May 8, 2024

No description provided.

@dconeybe dconeybe self-assigned this May 8, 2024
@dconeybe dconeybe merged commit 2f07042 into dataconnect May 8, 2024
@dconeybe dconeybe deleted the dconeybe/NullLists branch May 8, 2024 17:36
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (c897ea6) and merge commit (00fbfc1).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/3aVIwHOjsV.html

@google-oss-bot
Copy link
Contributor

The public api surface has changed for the subproject firebase-dataconnect:
error: Removed class com.google.firebase.dataconnect.BaseRef [RemovedClass]
error: Added class com.google.firebase.dataconnect.ConnectorConfig [AddedClass]
error: Added constructor com.google.firebase.dataconnect.DataConnectException(String,Throwable) [AddedMethod]
error: Removed class com.google.firebase.dataconnect.DataConnectGrpcClientKt [RemovedClass]
error: Added class com.google.firebase.dataconnect.DataConnectSettings [AddedClass]
error: Added class com.google.firebase.dataconnect.DataConnectSettingsKt [AddedClass]
error: Class com.google.firebase.dataconnect.FirebaseDataConnect changed class/interface declaration [ChangedClass]
error: Removed method com.google.firebase.dataconnect.FirebaseDataConnect.close() [RemovedMethod]
error: Added method com.google.firebase.dataconnect.FirebaseDataConnect.getConfig() [AddedAbstractMethod]
error: Removed method com.google.firebase.dataconnect.FirebaseDataConnect.getLocation() [RemovedMethod]
error: Removed method com.google.firebase.dataconnect.FirebaseDataConnect.getMutations() [RemovedMethod]
error: Removed method com.google.firebase.dataconnect.FirebaseDataConnect.getQueries() [RemovedMethod]
error: Removed method com.google.firebase.dataconnect.FirebaseDataConnect.getService() [RemovedMethod]
error: Method com.google.firebase.dataconnect.FirebaseDataConnect.getSettings has changed return type from com.google.firebase.dataconnect.FirebaseDataConnectSettings to com.google.firebase.dataconnect.DataConnectSettings [ChangedType]
error: Removed method com.google.firebase.dataconnect.FirebaseDataConnect.mutation(String,String,String,com.google.firebase.dataconnect.BaseRef.Codec<VariablesType,ResultType>) [RemovedMethod]
error: Added method com.google.firebase.dataconnect.FirebaseDataConnect.mutation(String,Variables,kotlinx.serialization.DeserializationStrategy<? extends Data>,kotlinx.serialization.SerializationStrategy<? super Variables>) [AddedAbstractMethod]
error: Removed method com.google.firebase.dataconnect.FirebaseDataConnect.query(String,String,String,com.google.firebase.dataconnect.BaseRef.Codec<VariablesType,ResultType>) [RemovedMethod]
error: Added method com.google.firebase.dataconnect.FirebaseDataConnect.query(String,Variables,kotlinx.serialization.DeserializationStrategy<? extends Data>,kotlinx.serialization.SerializationStrategy<? super Variables>) [AddedAbstractMethod]
error: Added method com.google.firebase.dataconnect.FirebaseDataConnect.useEmulator(String,int) [AddedAbstractMethod]
error: Removed method com.google.firebase.dataconnect.FirebaseDataConnect.Companion.getInstance(String,String,com.google.firebase.dataconnect.FirebaseDataConnectSettings) [RemovedMethod]
error: Removed method com.google.firebase.dataconnect.FirebaseDataConnect.Companion.getInstance(String,String,kotlin.jvm.functions.Function1<? super com.google.firebase.dataconnect.FirebaseDataConnectSettings.Builder,kotlin.Unit>) [RemovedMethod]
error: Removed method com.google.firebase.dataconnect.FirebaseDataConnect.Companion.getInstance(com.google.firebase.FirebaseApp,String,String,com.google.firebase.dataconnect.FirebaseDataConnectSettings) [RemovedMethod]
error: Removed method com.google.firebase.dataconnect.FirebaseDataConnect.Companion.getInstance(com.google.firebase.FirebaseApp,String,String,kotlin.jvm.functions.Function1<? super com.google.firebase.dataconnect.FirebaseDataConnectSettings.Builder,kotlin.Unit>) [RemovedMethod]
error: Removed class com.google.firebase.dataconnect.FirebaseDataConnect.Mutations [RemovedClass]
error: Removed class com.google.firebase.dataconnect.FirebaseDataConnect.Queries [RemovedClass]
error: Added class com.google.firebase.dataconnect.FirebaseDataConnectKt [AddedClass]
error: Removed class com.google.firebase.dataconnect.FirebaseDataConnectSettings [RemovedClass]
error: Removed class com.google.firebase.dataconnect.GraphQLException [RemovedClass]
error: Removed enum constant com.google.firebase.dataconnect.LogLevel.INFO [RemovedField]
error: Added enum constant com.google.firebase.dataconnect.LogLevel.NONE [AddedField]
error: Added enum constant com.google.firebase.dataconnect.LogLevel.WARN [AddedField]
error: Removed enum constant com.google.firebase.dataconnect.LogLevel.WARNING [RemovedField]
error: Added class com.google.firebase.dataconnect.LogLevelKt [AddedClass]
error: Removed class com.google.firebase.dataconnect.LoggerKt [RemovedClass]
error: Class com.google.firebase.dataconnect.MutationRef changed class/interface declaration [ChangedClass]
error: Added method com.google.firebase.dataconnect.MutationRef.execute(kotlin.coroutines.Continuation<? super com.google.firebase.dataconnect.MutationResult<Data,Variables>>) [AddedAbstractMethod]
error: Removed method com.google.firebase.dataconnect.MutationRef.execute(VariablesType,kotlin.coroutines.Continuation<? super ResultType>) [RemovedMethod]
error: Removed class com.google.firebase.dataconnect.NetworkTransportException [RemovedClass]
error: Added class com.google.firebase.dataconnect.OptionalVariableSerializer [AddedClass]
error: Class com.google.firebase.dataconnect.QueryRef changed class/interface declaration [ChangedClass]
error: Added method com.google.firebase.dataconnect.QueryRef.execute(kotlin.coroutines.Continuation<? super com.google.firebase.dataconnect.QueryResult<Data,Variables>>) [AddedAbstractMethod]
error: Removed method com.google.firebase.dataconnect.QueryRef.execute(VariablesType,kotlin.coroutines.Continuation<? super ResultType>) [RemovedMethod]
error: Added method com.google.firebase.dataconnect.QueryRef.subscribe() [AddedAbstractMethod]
error: Removed method com.google.firebase.dataconnect.QueryRef.subscribe(VariablesType) [RemovedMethod]
error: Class com.google.firebase.dataconnect.QuerySubscription changed class/interface declaration [ChangedClass]
error: Method com.google.firebase.dataconnect.QuerySubscription.getFlow has changed return type from kotlinx.coroutines.flow.Flow<com.google.firebase.dataconnect.QuerySubscription.Message<VariablesType,ResultType>> to kotlinx.coroutines.flow.Flow<com.google.firebase.dataconnect.QuerySubscriptionResult<Data,Variables>> [ChangedType]
error: Removed method com.google.firebase.dataconnect.QuerySubscription.getLastResult() [RemovedMethod]
error: Added method com.google.firebase.dataconnect.QuerySubscription.getQuery() [AddedAbstractMethod]
error: Removed method com.google.firebase.dataconnect.QuerySubscription.getVariables() [RemovedMethod]
error: Removed method com.google.firebase.dataconnect.QuerySubscription.reload() [RemovedMethod]
error: Removed method com.google.firebase.dataconnect.QuerySubscription.update(VariablesType) [RemovedMethod]
error: Removed class com.google.firebase.dataconnect.QuerySubscription.Message [RemovedClass]
error: Removed class com.google.firebase.dataconnect.QuerySubscriptionKt [RemovedClass]
error: Removed class com.google.firebase.dataconnect.ResultDecodeException [RemovedClass]
error: Removed package com.google.firebase.dataconnect.apiproposal [RemovedPackage]
error: Removed class com.google.firebase.dataconnect.generated.CreatePostMutation [RemovedClass]
error: Removed class com.google.firebase.dataconnect.generated.CreatePostMutationKt [RemovedClass]
error: Removed class com.google.firebase.dataconnect.generated.GetPostQuery [RemovedClass]
error: Removed class com.google.firebase.dataconnect.generated.GetPostQueryKt [RemovedClass]

Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly.

@firebase firebase locked and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants