Skip to content

Use find_program to get python in cmake #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Use find_program to get python in cmake #1156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c594de2
Use find_program to get python
a-maurice Nov 24, 2022
bd9931c
Merge branch 'main' into am-find_python
a-maurice Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,11 @@ option(FIREBASE_GITHUB_ACTION_BUILD
option(FIREBASE_QUICK_TEST
"Enable quick tests will skip tests which requires access to the SECRET" OFF)

set(FIREBASE_PYTHON_EXECUTABLE "python" CACHE FILEPATH
"The Python interpreter to use, such as one from a venv")
find_program(FIREBASE_PYTHON_EXECUTABLE
Copy link
Contributor

@dconeybe dconeybe Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this still be overridden by specifying -D FIREBASE_PYTHON_EXECUTABLE=xxx? I depend on that functionality.

Copy link
Contributor Author

@a-maurice a-maurice Nov 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, documentation suggested that, and confirmed it locally.

NAMES python3 python
DOC "The Python interpreter to use, such as one from a venv"
REQUIRED
)

set(FIREBASE_XCODE_TARGET_FORMAT "frameworks" CACHE STRING
"Format to output, 'frameworks' or 'libraries'")
Expand Down