Skip to content

Feature/ddb fix msg auth #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 1, 2020
Merged

Feature/ddb fix msg auth #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
901dc7c
remove use of std::to_string in auth integration test
DellaBitta Sep 1, 2020
4fde99c
fixed variable name
DellaBitta Sep 1, 2020
11470e4
use std::string::append directly
DellaBitta Sep 1, 2020
d31f939
messaging test fix candidate
DellaBitta Sep 1, 2020
9bc5df7
re-added guards against persistence auth tests on linux
DellaBitta Sep 1, 2020
39647c5
put pack newline
DellaBitta Sep 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions auth/integration_test/src/integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -389,10 +389,11 @@ TEST_F(FirebaseAuthTest, TestTokensAndAuthStateListeners) {
}

static std::string GenerateEmailAddress() {
std::string email =
"random_user_" +
std::to_string(app_framework::GetCurrentTimeInMicroseconds()) +
"@gmail.com";
char time_string[22];
snprintf(time_string, 22, "%d", app_framework::GetCurrentTimeInMicroseconds());
std::string email = "random_user_";
email.append(time_string);
email.append("@gmail.com");
LogDebug("Generated email address: %s", email.c_str());
return email;
}
Expand Down
5 changes: 4 additions & 1 deletion messaging/integration_test/src/integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,10 @@ static std::string ConstructHtmlToSendMessage(
"document.write('<h1>Failed to send notification.</h1>');"
"document.write('Status '+xhttp.status+': '+xhttp.response);"
"}},";
h += std::to_string(delay_seconds * 1000) + ");}</script>";
char delay_seconds_string[22];
snprintf(delay_seconds_string, 22, "%d", delay_seconds);
h += delay_seconds_string;
h += ");}</script>";
return h;
}

Expand Down