Skip to content

Use core implementation of aggregate query equality operator. #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Use core implementation of aggregate query equality operator. #1376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions firestore/src/main/aggregate_query_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,7 @@ Future<AggregateQuerySnapshot> AggregateQueryInternal::Get(

bool operator==(const AggregateQueryInternal& lhs,
const AggregateQueryInternal& rhs) {
// TODO(b/276440573) - there needs to be equals operator defined on
// api::AggregateQuery
return lhs.aggregate_query_.query() == rhs.aggregate_query_.query();
return lhs.aggregate_query_ == rhs.aggregate_query_;
}

} // namespace firestore
Expand Down
4 changes: 1 addition & 3 deletions firestore/src/main/aggregate_query_snapshot_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,7 @@ int64_t AggregateQuerySnapshotInternal::count() const { return count_result_; }

bool operator==(const AggregateQuerySnapshotInternal& lhs,
const AggregateQuerySnapshotInternal& rhs) {
// TODO(b/276440573) - there needs to be equals operator defined on
// api::AggregateQuery
return lhs.aggregate_query_.query() == rhs.aggregate_query_.query() &&
return lhs.aggregate_query_ == rhs.aggregate_query_ &&
lhs.count_result_ == rhs.count_result_;
}

Expand Down