Skip to content

Run iOS simulator install as root #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Run iOS simulator install as root #1379

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/gha/test_simulator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ def _create_and_boot_simulator(apple_platform, device_name, device_os):
print("::warning ::Unable to find %s version %s, will fall back to %s" % (apple_platform, device_os, available_versions[-1]))
device_os = available_versions[-1]

args = ["xcodes", "runtimes", "install", "%s %s" % (apple_platform, device_os)]
args = ["sudo", "xcodes", "runtimes", "install", "%s %s" % (apple_platform, device_os)]
Copy link
Contributor

@jonsimantov jonsimantov Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the info log message below to say it uses sudo; that way, if a user is running this on their machine, they won't be surprised by the password prompt.

Copy link
Contributor Author

@a-maurice a-maurice Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It prints out the args array, so the sudo should be included in the message

Copy link
Contributor

@jonsimantov jonsimantov Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's fine, though not quite as user-friendly as it could be. :P

logging.info("Download simulator: %s", " ".join(args))
subprocess.run(args=args, check=False)

Expand Down