Skip to content

Conversation

@a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Reduce iOS testing targets to just ios_target and simulator_target, as the Firebase Test Lab is primarily only supporting one version anymore, making the others unnecessary.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Dec 9, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to optimize the GitHub Actions CI/CD pipeline by removing unnecessary iOS testing targets. By focusing on the ios_target and simulator_target configurations, the change simplifies the testing matrix and reduces potential overhead, reflecting the current support model of Firebase Test Lab. This ensures that CI resources are efficiently utilized for relevant testing environments.

Highlights

  • Streamlined iOS Testing Targets: The pull request reduces the number of iOS testing targets in GitHub Actions to only ios_target and simulator_target. This change aligns with Firebase Test Lab's primary support for a single version, making other targets redundant.
  • Configuration Updates: The scripts/gha/print_matrix_configuration.py file has been updated to remove ios_min, ios_latest, simulator_min, and simulator_latest from the ios_device expansion key and their corresponding device definitions.
  • Documentation Refinement: The help text in scripts/gha/test_simulator.py for the --ios_device argument has been updated to reflect the removal of the simulator_min and simulator_latest options, now only listing simulator_target.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/integration_tests.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request streamlines the iOS testing configuration by removing several device targets from the GitHub Actions workflows. The changes in scripts/gha/print_matrix_configuration.py correctly remove ios_min, ios_latest, simulator_min, and simulator_latest from both the EXPANDED_KEY matrix and the TEST_DEVICES dictionary. The documentation in scripts/gha/test_simulator.py is also updated to reflect these removals. The changes are consistent and achieve the stated goal of simplifying the testing targets. The code is clean and I have no further suggestions.

@a-maurice a-maurice merged commit 62c772b into main Dec 10, 2025
28 of 45 checks passed
@a-maurice a-maurice deleted the am-ios_runners branch December 10, 2025 01:40
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Dec 10, 2025
@github-actions
Copy link

github-actions bot commented Dec 10, 2025

❌  Integration test FAILED

Requested by @a-maurice on commit 62c772b
Last updated: Tue Dec 9 19:38 PST 2025
View integration test log & download artifacts

Failures Configs
missing_log [BUILD] [ERROR] [Android] [1/3 os: windows]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Dec 10, 2025
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant