Skip to content

Handle retries in build reporting#1854

Merged
a-maurice merged 1 commit into
mainfrom
am-build_report
May 11, 2026
Merged

Handle retries in build reporting#1854
a-maurice merged 1 commit into
mainfrom
am-build_report

Conversation

@a-maurice
Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

The report_build_status script already sorts CI runs new to old, but was accidentally overriding newer attempts with older attempts because of this. Add logic to ignore older runs of the same name to handle this.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Running it locally.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label May 11, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the report_build_status.py script to ensure that only the most recent version of each log artifact is processed. By introducing a set to track artifact names and iterating through them in reverse chronological order, the script now correctly skips older attempts of the same artifact. I have no feedback to provide as there were no review comments.

@a-maurice a-maurice requested a review from AustinBenoit May 11, 2026 21:25
@a-maurice a-maurice merged commit 6c82c64 into main May 11, 2026
38 of 50 checks passed
@a-maurice a-maurice deleted the am-build_report branch May 11, 2026 23:03
@github-actions github-actions Bot added the tests: in-progress This PR's integration tests are in progress. label May 11, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

Integration test with FLAKINESS (succeeded after retry)

Requested by @a-maurice on commit 6c82c64
Last updated: Mon May 11 18:01 PDT 2026
View integration test log & download artifacts

Failures Configs
app_check [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseAppCheckTest.TestSignIn

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions Bot added the tests: succeeded This PR's integration tests succeeded. label May 12, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants