Skip to content

Change nightly status script to not depend on time#1863

Merged
a-maurice merged 2 commits into
mainfrom
am-build_report
Jun 3, 2026
Merged

Change nightly status script to not depend on time#1863
a-maurice merged 2 commits into
mainfrom
am-build_report

Conversation

@a-maurice
Copy link
Copy Markdown
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

The nightly report routinely fails to find source tests because it is relying on the time, which is inconsistent. Instead, check if the run was invoked via a schedule, and the determine if it is Firestore by using the time.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Running it locally.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Jun 2, 2026
@a-maurice a-maurice requested a review from AustinBenoit June 2, 2026 23:54
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the build status reporting script to select either the earliest or latest scheduled test run for a given day, removing the previous specific hour constraints. The reviewer identified critical issues in this new logic, including a logical bug in the date comparison (since comparing .date() objects on the same day will always evaluate to equal), unreachable code for non-Firestore runs, and suboptimal filtering order. A code suggestion was provided to resolve these issues by reordering the filters and comparing full datetime objects.

Comment thread scripts/gha/report_build_status.py Outdated
@a-maurice a-maurice merged commit 9ae22e9 into main Jun 3, 2026
38 checks passed
@a-maurice a-maurice deleted the am-build_report branch June 3, 2026 16:46
@github-actions github-actions Bot added the tests: in-progress This PR's integration tests are in progress. label Jun 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 3, 2026

❌  Integration test FAILED

Requested by @a-maurice on commit 9ae22e9
Last updated: Wed Jun 3 14:47 PDT 2026
View integration test log & download artifacts

Failures Configs
auth [TEST] [FAILURE] [tvOS] [macos] [tvos_simulator]
(2 failed tests)  FirebaseAuthTest.TestUpdateEmailAndPassword
  FirebaseAuthTest.TestVerifyBeforeUpdatingEmail
firestore [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirestoreTest.TestCanUpdateAnUnknownDocument
[TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: emulator_ftl_target]
(1 failed tests)  CRASH/TIMEOUT
messaging [BUILD] [ERROR] [Android] [1/3 os: macos]

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions Bot added the tests: failed This PR's integration tests failed. label Jun 3, 2026
@firebase-workflow-trigger firebase-workflow-trigger Bot removed the tests: in-progress This PR's integration tests are in progress. label Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants