Skip to content

Touch a file to see if we can test a subset of tests. #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 55 commits into from
Closed

Touch a file to see if we can test a subset of tests. #337

wants to merge 55 commits into from

Conversation

@jonsimantov
Copy link
Contributor

@jonsimantov jonsimantov commented Mar 19, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Mar 19, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Mar 19, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Mar 19, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Mar 19, 2021
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Mar 19, 2021
@jonsimantov jonsimantov added api: auth type: cleanup tests-requested: quick Trigger a quick set of integration tests. and removed tests: in-progress This PR's integration tests are in progress. api: auth type: cleanup labels Mar 19, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Mar 19, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Mar 19, 2021
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Mar 19, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Mar 19, 2021
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Mar 19, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Mar 19, 2021
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Mar 19, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Mar 19, 2021
@github-actions github-actions bot added tests: failed This PR's integration tests failed. and removed tests-requested: quick Trigger a quick set of integration tests. labels Mar 19, 2021
@github-actions github-actions bot removed the tests: succeeded This PR's integration tests succeeded. label Mar 19, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 19, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Mar 19, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Mar 19, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 19, 2021
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Mar 19, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Mar 19, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels Mar 19, 2021
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 19, 2021
@jonsimantov jonsimantov added the tests-requested: quick Trigger a quick set of integration tests. label Mar 19, 2021
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. tests: succeeded This PR's integration tests succeeded. labels Mar 19, 2021
@github-actions
Copy link

github-actions bot commented Mar 19, 2021 •
edited
Loading

✅  Integration test succeeded!

Requested by @jonsimantov on commit a2fb5f0
Last updated: Fri Mar 19 16:07:48 PDT 2021
View integration test results

@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 19, 2021
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Mar 19, 2021
jonsimantov added a commit that referenced this pull request Mar 20, 2021
@jonsimantov
Trigger integration tests by setting a "tests-requested" label. (#339)
8d14b71 
This PR adds some label-based triggers for integration tests, which allow the integration tests to be requested on a PR by setting the "tests-requested" label.

There are two modes for requesting tests, "quick" and "full":

"quick" tries to be clever and figure out a subset of APIs (and even platforms) to test. This heuristic is really simple right now (it just looks at directory names and, for platform, filenames) and if there is any ambiguity it will just run the normal suite of tests.

"full" just runs all the tests. Currently this is set to use an expanded test matrix, though this could be changed in the future.

The test workflow handles updating the labels and posting/updating a comment with the status of the integration tests as they run. All of the jobs that mess with labels and comments are skipped if the workflow wasn't run from the PR label.

(See #337—which won't be merged—for an example of "quick" mode in action, autodetecting to just run a subset of tests.)
@jonsimantov jonsimantov deleted the test/try_quick_testing branch March 20, 2021 00:28
@firebase firebase locked and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes tests: succeeded This PR's integration tests succeeded.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonsimantov