Skip to content

Conversation

@DellaBitta
Copy link
Contributor

Tests from the main repo are depenent on MOCK_METHOD() calls that aren't supported in 1.7. Updating our google test dependency to fix integration test compilation errors (b159716156).

@DellaBitta DellaBitta marked this pull request as ready for review June 23, 2020 19:52
@DellaBitta DellaBitta requested a review from vimanyu June 23, 2020 19:52
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DellaBitta DellaBitta merged commit b27df6e into dev Jun 23, 2020
@DellaBitta DellaBitta deleted the Feature/update_googletest_dependency branch June 23, 2020 20:12
jonsimantov pushed a commit that referenced this pull request Jul 8, 2020
* copied googletest.cmake file from latest Firestore version

* Updated copyright notice for 2020
jonsimantov pushed a commit that referenced this pull request Jul 10, 2020
* copied googletest.cmake file from latest Firestore version

* Updated copyright notice for 2020
@firebase firebase locked and limited conversation to collaborators Jul 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants