Skip to content

Mac unit test flake removal, part 1 #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 25, 2020
Merged

Mac unit test flake removal, part 1 #69

merged 5 commits into from
Jun 25, 2020

Conversation

@DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Jun 24, 2020 •
edited
Loading

  • Fixed issues with auth listeners not being invoked before their invocation count was verified.
  • Fixed an issue with Reauth test using an email credential with a anonymous user.
  • auth_test.cc - ensured the all new auth instances are created with signed out users, just in case the previous test failed and left one signed in.

@DellaBitta DellaBitta changed the title Remove some flake from the unit tests on mac. Mac unit test flake removal Jun 24, 2020
@DellaBitta DellaBitta marked this pull request as ready for review June 24, 2020 21:23
@DellaBitta DellaBitta assigned a-maurice and unassigned a-maurice Jun 24, 2020
@DellaBitta DellaBitta changed the title Mac unit test flake removal Mac unit test flake removal, part 1 Jun 24, 2020
@DellaBitta DellaBitta merged commit 81496dc into dev Jun 25, 2020
jonsimantov pushed a commit that referenced this pull request Jul 8, 2020
@DellaBitta @jonsimantov
Mac unit test flake removal, part 1 (#69)
f508c2c 
* Ensure auth_test creates an auth object with no signed in users.

* Add a utility to easily sleep for auth listeners to receive their callbacks

* added sleep before verification of idtoken and authstate listeners

* reworked reauthentication test to sign in and reauth with email credentials.

* put back MaybeWaitForFuture in Setup()
jonsimantov pushed a commit that referenced this pull request Jul 8, 2020
@DellaBitta @jonsimantov
Mac unit test flake removal, part 1 (#69)
51f3760 
* Ensure auth_test creates an auth object with no signed in users.

* Add a utility to easily sleep for auth listeners to receive their callbacks

* added sleep before verification of idtoken and authstate listeners

* reworked reauthentication test to sign in and reauth with email credentials.

* put back MaybeWaitForFuture in Setup()
jonsimantov pushed a commit that referenced this pull request Jul 10, 2020
@DellaBitta @jonsimantov
Mac unit test flake removal, part 1 (#69)
2bc82bf 
* Ensure auth_test creates an auth object with no signed in users.

* Add a utility to easily sleep for auth listeners to receive their callbacks

* added sleep before verification of idtoken and authstate listeners

* reworked reauthentication test to sign in and reauth with email credentials.

* put back MaybeWaitForFuture in Setup()
@firebase firebase locked and limited conversation to collaborators Jul 26, 2020
@DellaBitta DellaBitta deleted the Feature/macos-unit-tests branch July 28, 2020 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-maurice a-maurice a-maurice approved these changes

@jonsimantov jonsimantov Awaiting requested review from jonsimantov

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DellaBitta @a-maurice @googlebot