Skip to content

Conversation

@cynthiajoan
Copy link
Contributor

Add encrypted files for integration test

Copy link
Contributor

@a-maurice a-maurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the path forced to be scripts/gha-encrypted/..., or can it be changed? Also, assuming you haven't already, can you prep a doc on how this got generated, and how we can use it with actions?

@vimanyu
Copy link
Contributor

vimanyu commented Jun 29, 2020

+1 to a document detailing the expected workflow.
I noticed a decrypt file and am guessing the passphrase is stored as a secret on Github. So through Github actions, we should be able decrypt these files. It might be worth testing if a forked repo will have access to these secrets?

@paulb777
Copy link
Member

A forked repo does NOT have access. See examples for addressing this in https://github.com/firebase/firebase-ios-sdk/tree/master/.github/workflows

@cynthiajoan
Copy link
Contributor Author

A forked repo does NOT have access. See examples for addressing this in https://github.com/firebase/firebase-ios-sdk/tree/master/.github/workflows

Is this the commit that addresses this? firebase/firebase-ios-sdk@de91df6

@paulb777
Copy link
Member

@cynthiajoan That commit is to stop running push jobs on the private GitHub mirror since they were mostly redundant and especially expensive.

Managing forks or not is done by checking the secret environment variable like https://github.com/firebase/firebase-ios-sdk/blob/master/.github/workflows/auth.yml#L100

@vimanyu
Copy link
Contributor

vimanyu commented Jun 30, 2020

Just a note for when we incorporate this into a Github workflow. We might have to install "gpg" in a separate step. I think the iOS repo doesnt run into this because out of all the runners, mac is the only one with "gpg" pre-installed.

https://help.github.com/en/actions/reference/software-installed-on-github-hosted-runners

@cynthiajoan cynthiajoan merged commit e38e505 into dev Jun 30, 2020
@cynthiajoan cynthiajoan deleted the feature/secrets branch July 7, 2020 17:35
@firebase firebase locked and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants