Skip to content

attempt to add a longer sleep for auth test flake #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

attempt to add a longer sleep for auth test flake #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ba4dad
attempt to add a longer sleep for auth test flake
DellaBitta Jul 6, 2020
629a182
increasing scheduler test delay for deflakiness
DellaBitta Jul 6, 2020
f3ae59f
altered ScehdulerTest.RepeatCallbackWithDelay to be a bit more forgiving
DellaBitta Jul 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/tests/scheduler_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ TEST_F(SchedulerTest, RepeatCallbackWithDelay) {
int error = abs(actual_delay - delay);
printf("Delay: %dms. Actual delay: %dms. Error: %dms\n", delay, actual_delay,
error);
EXPECT_TRUE(error < 0.1 * internal::kMillisecondsPerSecond);
EXPECT_TRUE(error < 0.2 * internal::kMillisecondsPerSecond);

// Wait for it to repeat 100 times
for (int i = 0; i < 100; ++i) {
Expand Down
2 changes: 1 addition & 1 deletion auth/tests/desktop/test_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ class AuthStateChangesCounter : public detail::ListenerChangeCounter,
class SleepUponDestruction {
public:
~SleepUponDestruction() {
firebase::internal::Sleep(200);
firebase::internal::Sleep(1000);
}
};

Expand Down