Update to Firebase iOS SDK 9.0.0 with necessary changes for Swift support and Firestore #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, which now just returns a google_firestore_v1_Value instead of a Message<google_firestore_v1_Value>
…nd other improvements)
…g Objective-C parts of the iOS SDK
This fixes the following build error:
```
FIRFirestore.h:147:20: error: unknown attribute 'swift_async' ignored [-Werror,-Wunknown-attributes]
__attribute__((swift_async(none))); // Disable async import due to #9426.
^
1 error generated.
```
which was introduced by firebase/firebase-ios-sdk#9502
This is an attempt to fix the following build error:
```
Traceback (most recent call last):
File "Firestore/Protos/tmphmjWeu.py", line 25, in <module>
import nanopb_generator as nanopb
File "nanopb/generator/nanopb_generator.py", line 25, in <module>
import google.protobuf.text_format as text_format
File "protobuf/python/google/protobuf/text_format.py", line 51, in <module>
import six
ImportError: No module named six
```
e.g. https://github.com/firebase/firebase-cpp-sdk/runs/6034310890
…he problem. This reverts commit 56553d9.
…ts usage ubiquitous" It seemed to cause problems with the build. There is a better way in the iOS SDK anyways. This reverts commit c6346fd.
This fixes several test failures due to incorrect handling of startAfter and endBefore resulting from a change in core::Bound from "before" to "inclusive" in firebase/firebase-ios-sdk#9519 Namely, this fixes the following failure: ``` cursor_test.cc:250: Failure Expected equality of these values: std::vector<std::string>({"c", "f", "b", "e"}) Which is: { "c", "f", "b", "e" } QuerySnapshotToIds(snapshot) Which is: { "c", "f" } [ FAILED ] FirestoreIntegrationTest.TimestampsCanBePassedToQueriesAsLimits ``` e.g. https://github.com/firebase/firebase-cpp-sdk/runs/6044737005
Add Swift headers from 9.0.0 zip release.
github-actions
bot
added
the
tests: in-progress
Integration test with FLAKINESS (succeeded after retry)Requested by @jonsimantov on commit e4f7f12
Add flaky tests to go/fpl-cpp-flake-tracker |
jonsimantov
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
…/firebase-cpp-sdk into other/test_ios_900_pods
firebase-workflow-trigger
bot
removed
the
tests: in-progress
jonsimantov
added
the
tests-requested: quick
github-actions
bot
added
tests: in-progress
jonsimantov
changed the title
github-actions
bot
added
the
tests: succeeded
firebase-workflow-trigger
bot
removed
the
tests: in-progress
DellaBitta
approved these changes
May 5, 2022
a-maurice
approved these changes
May 5, 2022
github-actions
bot
added
tests: in-progress
firebase-workflow-trigger
bot
removed
the
tests: in-progress
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
9.0.0 cocoapods have a number of changes, including some SDK implementations moved to Swift. This change adds copies of the Swift bridging headers to our source repo and fixes #include/#import statements to pull in the right things (and modifies the update-dependencies workflow to pull in those files each time). Integration tests need an empty .swift file to ensure the Swift runtime is included.
This also includes changes from #898 to fix Firestore, plus some header path fixes.
AdMob dependency has been updated to a placeholder version that's compatible with 9.0.0.
Finally, Firebase iOS 9.x requires Xcode 13, so update our Xcode version to 13.3.1 (which fixes a nasty bug in 13.2.1 with iOS 11/12).
Testing
Integration tests run via label.
C++ packaging workflow manually run.
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.