Skip to content

Pass in -j N to cmake to speed up desktop testapp build. #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2022
Merged

Pass in -j N to cmake to speed up desktop testapp build. #933

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a57b550
Pass in -j to cmake --build when building desktop testapps.
jonsimantov May 6, 2022
6f3f582
Change the default value for FLAGS.jobs to the # of cpu cores (max 4)
jonsimantov May 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion scripts/gha/build_testapps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,20 @@
"arch", "x64",
"(Desktop only) Which architecture to build: x64 (all) or arm64 (Mac only).")

# Get the number of CPUs for the default value of FLAGS.jobs
CPU_COUNT = os.cpu_count();
# If CPU count couldn't be determined, default to 2.
DEFAULT_CPU_COUNT = 2
if CPU_COUNT is None: CPU_COUNT = DEFAULT_CPU_COUNT
# Cap at 4 CPUs.
MAX_CPU_COUNT = 4
if CPU_COUNT > MAX_CPU_COUNT: CPU_COUNT = MAX_CPU_COUNT

flags.DEFINE_integer(
"jobs", CPU_COUNT,
"(Desktop only) If > 0, pass in -j <number> to make CMake parallelize the"
" build. Defaults to the system's CPU count (max %s)." % MAX_CPU_COUNT)

flags.DEFINE_multi_string(
"cmake_flag", None,
"Pass an additional flag to the CMake configure step."
Expand Down Expand Up @@ -458,7 +472,8 @@ def _build_desktop(sdk_dir, cmake_flags):
cmake_configure_cmd += ["-DCMAKE_OSX_ARCHITECTURES=%s" %
("arm64" if FLAGS.arch == "arm64" else "x86_64")]
_run(cmake_configure_cmd + cmake_flags)
_run(["cmake", "--build", ".", "--config", "Debug"])
_run(["cmake", "--build", ".", "--config", "Debug"] +
["-j", str(FLAGS.jobs)] if FLAGS.jobs > 0 else [])


def _get_desktop_compiler_flags(compiler, compiler_table):
Expand Down