Move common auth items into common path #1026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taeold
requested changes
Feb 1, 2022
| }, options); | ||
| } | ||
|
|
||
| export class UserRecordMetadata implements firebase.auth.UserMetadata { |
Contributor
There was a problem hiding this comment.
I think it's possible that we break some user's code if we remove exported class like this one (similarly for any other exported objects)
Let's create an alias to prevent breaking change (and maybe add a note in go/cf3-v4-sdk to clean it up in the next major version.
Contributor
Author
There was a problem hiding this comment.
Oh yeah that's a great point. I re-exported them in the auth code path, added a todo comment about yanking them, and updated that doc.
taeold
approved these changes
Feb 1, 2022
inlined
approved these changes
Feb 2, 2022
| // SOFTWARE. | ||
|
|
||
| import * as firebase from 'firebase-admin'; | ||
| import * as _ from 'lodash'; |
Member
There was a problem hiding this comment.
ew. We generally don't allow lodash anymore. I guess I can let it slide because you're just moving code...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple refactor that moves common auth code pieces into the common directory under the identity namespace.