Update docs for root namespace #1101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inlined
changed the title
colerogers
requested changes
May 9, 2022
egilmorez
reviewed
May 9, 2022
Contributor
egilmorez
left a comment
egilmorez
left a comment
There was a problem hiding this comment.
A few thoughts Thomas, thanks!
| __endpoint: ManifestEndpoint; | ||
|
|
||
| /** | ||
| * The callback passed to the CloudFunction constructor. |
Contributor
There was a problem hiding this comment.
Is CloudFunction a literal?
|
|
||
| /** A handler for CloudEvents. */ | ||
| /** | ||
| * A handler for CloudEvents. |
Contributor
There was a problem hiding this comment.
Is "CloudEvents" a literal?
Member
Author
There was a problem hiding this comment.
Kinda? It's the name of a class, but it's also the name of a specification (which is what I intended here). The capitalization is what is at https://cloudevents.io
colerogers
approved these changes
May 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify docs for the root namespace. Some basic changes:
@betaindexbecause it is not ready for use (if you want, I can just mark everything as @alph instead, but IDK if we can avoid documenting the namespace at all.