-
Notifications
You must be signed in to change notification settings - Fork 218
Update docs for root namespace #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
929b421
Attempted fix; not sure why some things aren't showing up
inlined 9835dc2
Update docs; pull params namespace
inlined 9f840c4
Don't try to use bulleted list in field comments; they don't render
inlined 49bc1b4
Merge branch 'master' into inlined.docs.root
inlined 9eb971e
Yank @beta tags; run formatter
inlined 7c622ee
PR feedback
inlined a30cc2b
Merge branch 'master' into inlined.docs.root
inlined File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,6 +56,8 @@ export interface TriggerAnnotation { | |
| /** | ||
| * A CloudEventBase is the base of a cross-platform format for encoding a serverless event. | ||
| * More information can be found in https://github.com/cloudevents/spec | ||
| * @typeParam T - The type of the event data. | ||
| * @beta | ||
| */ | ||
| export interface CloudEvent<T> { | ||
| /** Version of the CloudEvents spec for this event. */ | ||
|
|
@@ -80,12 +82,28 @@ export interface CloudEvent<T> { | |
| data: T; | ||
| } | ||
|
|
||
| /** A handler for CloudEvents. */ | ||
| /** | ||
| * A handler for CloudEvents. | ||
| * @typeParam EventType - The kind of event this function handles. | ||
| * Always a subclass of CloudEvent<> | ||
| * @beta | ||
| */ | ||
| export interface CloudFunction<EventType extends CloudEvent<unknown>> { | ||
| (raw: CloudEvent<unknown>): any | Promise<any>; | ||
|
|
||
| /** @alpha */ | ||
| __trigger?: unknown; | ||
| /** @alpha */ | ||
| __endpoint: ManifestEndpoint; | ||
|
|
||
| /** | ||
| * The callback passed to the CloudFunction constructor. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is CloudFunction a literal? |
||
| * Use run to test a CloudFunction | ||
| * @param event - The parsed event to handle. | ||
| * @returns Any return value. Google Cloud Functions awaits any promise | ||
| * before shutting down your function. Resolved return values | ||
| * are only used for unit testing purposes. | ||
| * @beta | ||
| */ | ||
| run(event: EventType): any | Promise<any>; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is "CloudEvents" a literal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda? It's the name of a class, but it's also the name of a specification (which is what I intended here). The capitalization is what is at https://cloudevents.io
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough! :)