-
Notifications
You must be signed in to change notification settings - Fork 218
Fix prerelease publishing #1764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Allows 'prerelease' as a version argument to increment RC versions. Ensures that the version bump commit and tag are pushed to GitHub even for pre-releases, preventing subsequent runs from attempting to publish the same version.
Manually updated package.json to 7.0.0-rc.0 to match npm. Updated publish.sh to correctly handle prerelease argument and push commits.
Summary of ChangesHello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a critical issue in the release process where prerelease versions were not being handled correctly, leading to failures in subsequent publishing attempts. The changes enable the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully adds support for 'prerelease' versioning and ensures that version bumps for pre-releases are pushed to GitHub, which resolves the issue described. The logic for handling the new 'prerelease' argument is sound. I have one suggestion to refactor the publishing script to improve maintainability by removing a duplicated command.
| echo "Pushing to GitHub..." | ||
| git push origin master --tags | ||
| echo "Pushed to GitHub." | ||
|
|
||
| if [[ $PRE_RELEASE != "" ]]; then | ||
| echo "Published a pre-release version. Skipping post-release actions." | ||
| exit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While adding the git push here correctly pushes pre-release tags, it introduces a code duplication issue. For a full release, git push origin master --tags is now called twice: once here, and once again on line 147 after the changelog is cleaned up. This results in an extra, unnecessary push operation for full releases.
To improve this, you can move the push logic inside the if [[ $PRE_RELEASE != "" ]] block. This ensures the push only happens once at the correct time for both pre-releases and full releases, making the script cleaner and more efficient.
| echo "Pushing to GitHub..." | |
| git push origin master --tags | |
| echo "Pushed to GitHub." | |
| if [[ $PRE_RELEASE != "" ]]; then | |
| echo "Published a pre-release version. Skipping post-release actions." | |
| exit | |
| if [[ $PRE_RELEASE != "" ]]; then | |
| echo "Pushing to GitHub..." | |
| git push origin master --tags | |
| echo "Pushed to GitHub." | |
| echo "Published a pre-release version. Skipping post-release actions." | |
| exit | |
| fi |
brittanycho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wdyt of the gemini-code-assist comments (re: git push)?
Allows 'prerelease' as a version argument to increment RC versions. Ensures that the version bump commit and tag are pushed to GitHub even for pre-releases, preventing subsequent runs from attempting to publish the same version.
The current release "fails" to create a second prerelease 😢