fix: allow JsonSecretParam in secrets array

[taeold]

JsonSecretParam was not accepted in the secrets option array because:

1. The type was defined as (string | SecretParam)[], excluding JsonSecretParam
2. Runtime converters only checked for instanceof SecretParam

Fixes #1783

[gemini-code-assist]

Summary of Changes

Hello @taeold, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where JsonSecretParam was not properly recognized or accepted within the secrets configuration array for Firebase Functions. The changes involve expanding the relevant TypeScript type definitions and updating the runtime conversion mechanisms to ensure JsonSecretParam instances are correctly processed, thereby improving the flexibility and consistency of secret management.

Highlights

• Type Definition Update: The type definition for the secrets option array has been updated to explicitly include JsonSecretParam, resolving an issue where it was previously excluded.
• Runtime Conversion Logic: The runtime conversion logic for secrets has been enhanced to correctly identify and process instances of JsonSecretParam, alongside SecretParam and plain strings.
• New Test Cases: New compile-time and runtime tests have been added for both v1 and v2 functions to ensure that JsonSecretParam is correctly accepted and handled within the secrets array.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes an issue where JsonSecretParam was not accepted in the secrets array. The changes are thorough, updating type definitions and runtime logic for both v1 and v2 functions, and include new tests to cover this case. My review includes suggestions to simplify the newly added runtime logic for handling different secret types. The proposed simplification makes the code more concise and readable by leveraging the type information of SupportedSecretParam.