Skip to content

Conversation

@taeold
Copy link
Contributor

@taeold taeold commented Dec 16, 2025

Export SecretParam, JsonSecretParam, StringParam, BooleanParam, IntParam, ListParam, and Param types to allow users to import them for type annotations.

Fixes #1777

Export SecretParam, JsonSecretParam, StringParam, BooleanParam, IntParam,
ListParam, and Param types to allow users to import them for type annotations.

Fixes #1777
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @taeold, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the developer experience for Firebase Functions users by making essential parameter types publicly accessible. By exporting types such as SecretParam and StringParam, developers can now leverage TypeScript's full potential for type safety and clarity when defining and interacting with function parameters, resolving a long-standing request from the community.

Highlights

  • Type Export: The pull request exports several parameter types, including Param, SecretParam, JsonSecretParam, StringParam, BooleanParam, IntParam, and ListParam, from the firebase-functions/params module.
  • Improved Type Annotations: This change allows users to import these types directly, enabling more robust and explicit type annotations in their Firebase Functions code.
  • Issue Resolution: The modification directly addresses and fixes issue SecretParam and other param types not exported from firebase-functions/params in v7.0.0 #1777, which requested the ability to import these specific parameter types.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request exports several parameter types from firebase-functions/params to make them available for user type annotations, which is a useful addition. The implementation is correct. I've added one comment with a suggestion to merge the new export type statement with an existing one for better code style and consistency.

@taeold taeold added this pull request to the merge queue Dec 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 16, 2025
@taeold taeold enabled auto-merge December 16, 2025 19:58
@taeold taeold added this pull request to the merge queue Dec 16, 2025
Merged via the queue into master with commit bb407c6 Dec 16, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SecretParam and other param types not exported from firebase-functions/params in v7.0.0

3 participants