Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the CHANGELOG.md to include recent changes. The review suggests restructuring the file with a top-level heading and version section, as well as improving the formatting and capitalization of the entries for better consistency.
Comment on lines
+1
to
+2
| - Accept BooleanParams in CallableOptions (#1854) | ||
| - rotate the npmrc key to robot account (#1857) |
Contributor
There was a problem hiding this comment.
The CHANGELOG.md file lacks a standard structure. It should include a top-level heading and a version section (e.g., ## Unreleased) to organize the entries. Additionally, the second entry should be capitalized for consistency and use .npmrc to correctly refer to the configuration file.
Suggested change
| - Accept BooleanParams in CallableOptions (#1854) | |
| - rotate the npmrc key to robot account (#1857) | |
| # Changelog | |
| ## Unreleased | |
| - Accept BooleanParams in CallableOptions (#1854) | |
| - Rotate the .npmrc key to robot account (#1857) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog was missing recent updates.