Update firebase-admin in integration tests to v5.12.0 #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for contributing! |
thechenky
pushed a commit
that referenced
this pull request
Jul 24, 2019
* Firebase Test Lab Provider * Minor code cleanups * Update event type and provider namespace to new format * Rename testlab to testLab * Add testMatrix handler function to HandlerBuilder * Resolve PR comments * Resolve PR comments * Add changelog message for new Test Lab trigger * Resolve minor pr comments * Promisify makeRequest and reuse in existing http request helpers * Fix testLab import in handler-builder.ts * Necessary fixes after merging master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating firebase-admin version in the integration test dependencies to v5.12.0 so that it matches the peer dependency requirement of firebase-functions. This fixes the integration tests.
/cc @laurenzlong for review