Pass the raw Express request to CallableContext #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenzlong
suggested changes
Jun 19, 2018
Contributor
laurenzlong
left a comment
laurenzlong
left a comment
There was a problem hiding this comment.
Thanks so much! Just some minor comments on the test.
spec/providers/https.spec.ts
Outdated
| }); | ||
| }); | ||
|
|
||
| it('should handle raw request', async () => { |
Contributor
There was a problem hiding this comment.
rephrase to: "should expose raw request"
spec/providers/https.spec.ts
Outdated
| httpRequest: mockRequest, | ||
| expectedData: null, | ||
| callableFunction: (data, context) => { | ||
| expect(context.auth).to.be.undefined; |
Contributor
There was a problem hiding this comment.
This line can be removed, distracts from seeing what the point of the test is.
spec/providers/https.spec.ts
Outdated
| expectedData: null, | ||
| callableFunction: (data, context) => { | ||
| expect(context.auth).to.be.undefined; | ||
| expect(context.instanceIdToken).to.be.undefined; |
Contributor
There was a problem hiding this comment.
Same here, this line can be removed.
laurentpellegrino
force-pushed
the
https-callable-raw-request
branch
from
e0d8d55 to
e03ccc2
Compare
Contributor
Author
|
Thanks for the review. Your suggestions have been applied. |
laurenzlong
approved these changes
Jun 20, 2018
Contributor
|
Looks great! Thanks again for taking the time to do this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes what was originally proposed in #262.
Here is a summary of the spec shared by laurenzlong: