Change release function to only decrement counter after waiting 2 min #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjhuijsman
suggested changes
Apr 10, 2017
Contributor
There was a problem hiding this comment.
I like this approach!
For my paranoia, could you add a test for each of these properties:
- Multiple retain() calls all increment the counter.
- Multiple release() calls spread apart in time each decrement the counter by only 1. In other words: for a refcount of 2, a release at T=0 and a release at T=30 means that cleanup happens at T=30+120=150, not at T=0+120.
Contributor
Author
|
Great test cases! Just added them. |
rjhuijsman
approved these changes
Apr 11, 2017
Contributor
rjhuijsman
left a comment
rjhuijsman
left a comment
There was a problem hiding this comment.
I ran my repro with your branch installed. See the effect for yourself:
:)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing a bug where database connections were being closed even if a function was invoked recently. I changed the model for ref counting, to only decrement the counter after waiting 2 minutes. Whereas the old model decremented the counter right away, and then waited 2 minutes to destroy the app. With the new changes, an app will only be destroyed if there's 2 minutes of no invocations.
Code sample
N/A