Improving stability and speed of intergration tests #384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e6 and node8 on different projects
thechenky
suggested changes
Jan 16, 2019
| .then(() => { | ||
| console.log('All tests pass!'); | ||
| resp.status(200).send('PASS'); | ||
| resp.status(200).send('PASS \n'); |
Contributor
There was a problem hiding this comment.
nice, this was bothering me :P
integration_test/run_tests.sh
Outdated
| deploy | ||
| waitForPropagation | ||
| run_tests | ||
| else |
Contributor
There was a problem hiding this comment.
It took me some time to understand the difference between the two flows, but I understand why you needed to do them like this. Perhaps in the future we can keep the parallel deploys for node6 and node8 and find a way to have each test have a different name - that way we can keep the same flow for when the projects are the same (both would use the else part here).
Co-Authored-By: joehan <joehanley@google.com>
thechenky
reviewed
Jan 16, 2019
| deploy | ||
| waitForPropagation | ||
| run_all_tests | ||
| fi |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
thechenky
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Code sample
./run_tests.sh project1 project2 // runs node6 tests on project1 and node8 tests on project2, in parallel
./run_tests.sh projectId // runs node6 and node8 tests on projectId, in series