Skip to content

Conversation

@merlinnot
Copy link
Contributor

Description

This PR enforces Prettier formatting for more file types used in the project and excludes all files that should not be formatted:

  • package.json, as npm has it's own way of formatting
  • lib, as it's just a compilation output (previously it was formatted too)
  • unparseable JSON file in integration tests, so Prettier doesn't fix it

This PR is split in two commits, one changes the configuration, the other ones applies it automatically.

Code sample

Not relevant.

@thechenky
Copy link
Contributor

Need to run npm run format:fix on this branch, I'll hold off for now as I have to clone your fork to do that.

@thechenky
Copy link
Contributor

Ended up running the formatter fix after all. Merging in now.

@thechenky thechenky merged commit 3f1cdd8 into firebase:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants