Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ All submissions, including submissions by project members, require review. We
use GitHub pull requests for this purpose. Consult [GitHub Help] for more
information on using pull requests.

[GitHub Help]: https://help.github.com/articles/about-pull-requests/
[github help]: https://help.github.com/articles/about-pull-requests/
6 changes: 4 additions & 2 deletions .github/ISSUE_TEMPLATE/---feature-request.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
---
name: "\U0001F4A1 Feature Request"
about: Have a feature you'd like to see in the functions SDK? Request it through our
about:
Have a feature you'd like to see in the functions SDK? Request it through our
support channel.
title: ''
labels: ''
assignees: ''
---
<!-- DO NOT DELETE

<!-- DO NOT DELETE
validate_template=false
template_path=.github/ISSUE_TEMPLATE/---feature-request.md
-->
Expand Down
11 changes: 5 additions & 6 deletions .github/ISSUE_TEMPLATE/---report-a-bug.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
---
name: "⚠️ Report a Bug"
name: '⚠️ Report a Bug'
about: Think you found a bug in the SDK? Report it here.
title: ''
labels: ''
assignees: ''

---
<!-- DO NOT DELETE

<!-- DO NOT DELETE
validate_template=true
template_path=.github/ISSUE_TEMPLATE/---report-a-bug.md
-->
Expand All @@ -21,11 +21,13 @@ template_path=.github/ISSUE_TEMPLATE/---report-a-bug.md
be fixed in the latest versions. -->

**node:**

<!-- Run node --version and print the output here-->

**firebase-functions:**

**firebase-tools:**

<!-- Run firebase --version and print the output here-->

**firebase-admin:**
Expand All @@ -34,17 +36,14 @@ be fixed in the latest versions. -->

<!-- Provide a minimal, complete, and verifiable example (http://stackoverflow.com/help/mcve) -->


### [REQUIRED] Steps to reproduce

<!-- Provide the steps needed to reproduce the issue given the above test case. -->


### [REQUIRED] Expected behavior

<!-- What is the expected behavior? -->


### [REQUIRED] Actual behavior

<!-- Please copy and paste any error logs from https://console.firebase.google.com/project/_/functions/logs.
Expand Down
7 changes: 3 additions & 4 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ and make note of the following:

Run the linter and test suite
==============================
Run `npm test` to make sure your changes compile properly and the tests all pass on your local machine.
We've hooked up this repo with continuous integration to double check those things for you.
Run `npm test` to make sure your changes compile properly and the tests all pass on your local machine.
We've hooked up this repo with continuous integration to double check those things for you.

Add tests (if applicable)
==============================
Expand All @@ -20,12 +20,11 @@ before sending PRs. We cannot accept code without this.

-->


### Description

<!-- Are you fixing a bug? Implementing a new feature? Make sure we have the context around your change.
Link to other relevant issues or pull requests. -->

### Code sample

<!-- Proposing an API change? Provide code samples showing how the API will be used. -->
<!-- Proposing an API change? Provide code samples showing how the API will be used. -->
3 changes: 3 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
lib
package.json
spec/fixtures/credential/unparsable.key.json
6 changes: 3 additions & 3 deletions integration_test/README.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
How to Use
---------
## How to Use

***ATTENTION***: Running this test will wipe the contents of the Firebase project(s) you run it against. Make sure you use disposable Firebase project(s)!
**_ATTENTION_**: Running this test will wipe the contents of the Firebase project(s) you run it against. Make sure you use disposable Firebase project(s)!

Run the integration test as follows:

```bash
./run_tests.sh <project_id> [<project_id2>]
```

If just one project_id is provided, the both the node6 and node8 tests will be run on that project, in series. If two project_ids are provided, the node6 tests will be run on the first project and the node8 tests will be run on the second one, in parallel.

The tests run fully automatically, and will print the result on standard out. The integration test for HTTPS is that it properly kicks off other integration tests and returns a result. From there the other integration test suites will write their results back to the database, where you can check the detailed results if you'd like.
8 changes: 2 additions & 6 deletions integration_test/functions/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,7 @@
"noImplicitAny": false,
"outDir": "lib",
"declaration": true,
"typeRoots": [
"node_modules/@types"
]
"typeRoots": ["node_modules/@types"]
},
"files": [
"src/index.ts"
]
"files": ["src/index.ts"]
}
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
"build:pack": "rm -rf lib && npm install && tsc -p tsconfig.release.json && npm pack",
"build:release": "npm install --production && npm install typescript firebase-admin && tsc -p tsconfig.release.json",
"build": "tsc -p tsconfig.release.json",
"format": "prettier --check '**/*.ts'",
"format:fix": "prettier --write '**/*.ts'",
"format": "prettier --check '**/*.{json,md,ts,yml,yaml}'",
"format:fix": "prettier --write '**/*.{json,md,ts,yml,yaml}'",
"lint": "tslint --config tslint.json --project tsconfig.json ",
"lint:fix": "tslint --config tslint.json --fix --project tsconfig.json",
"test": "mocha -r ts-node/register ./spec/index.spec.ts"
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"compilerOptions": {
"resolveJsonModule": true,
"sourceMap": true,
"sourceMap": true
},
"extends": "./tsconfig.release.json",
"include": ["./src/**/*.ts", "./spec/**/*.ts"]
Expand Down