Allow "npm run build:pack" to work even in a cleanly-cloned directory #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; previously the lack of a plain 'npm install' command caused it to fail with errors like "Cannot find module 'lodash'".
laurenzlong
approved these changes
Jul 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow "npm run build:pack" to work even in a cleanly-cloned directory; previously the lack of an "npm install" command in that directive caused it to fail with errors like "Cannot find module 'lodash'" if the developer hadn't run "npm install" manually before.
We no longer need to "npm install typescript", because it's a dev-dependency. We still need to install firebase-admin, since it's a peer dependency.