[FR]: Avoid if it's possible hardcoded strings to reduce framework size

[jesus-mg-ios]

Description

I'm wondering if is possible reduce the comments in asserts and string hardcoded that could have no impact in clients sdks, because they are for development purposes.
Doing this the binary size could be reduced.

As examples, of what a binary nowadays contains because it uses firebase.

firebase-ios-sdk/Firestore/core/src/remote/exponential_backoff.cc

Line 68 in fcdb554

"Initial delay can't be greater than max delay");

firebase-ios-sdk/Firestore/core/src/util/filesystem_win.cc

Line 137 in fcdb554

StringFormat("Could not delete directory %s", path.ToUtf8String()));

firebase-ios-sdk/Firestore/Source/API/FSTUserDataReader.mm

Line 296 in fcdb554

ThrowInvalidArgument("Nested arrays are not supported");

firebase-ios-sdk/Firestore/Source/API/FSTUserDataReader.mm

Line 584 in fcdb554

HARD_ASSERT(_databaseID == databaseId, "Database %s cannot encode reference from %s",

firebase-ios-sdk/Firestore/core/src/util/random_access_queue.h

Line 111 in fcdb554

"The front element in the queue should not be marked as \"removed\"");

API Proposal

No response

Firebase Product(s)

AB Testing, Analytics, App Check, App Distribution, Authentication, Crashlytics, Database, DynamicLinks, Firestore, Functions, In-App Messaging, Installations, ML Model Downloader, Messaging, Performance, Remote Config, Storage, Vertex AI

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[paulb777]

In Objective C, asserts are compiled out in release mode. It looks like we do something different in C++ code.

[dconeybe]

Hi @jesus-mg-ios. Could you elaborate on your desire to reduce your binary size? We hear this request often for our web SDKs, which are incredibly sensitive to code size; however, this is an unusual request for an iOS SDK. Have you measured the binary size reduction that would be gained from stripping out these strings? My gut tells me that the size saved would be negligible compared to the size of an entire IPA.

[jesus-mg-ios]

It's a combined effort. We haven't specifically counted how many strings are leaked into Firestore and other binaries that might not make sense or work in production. You know there's an alert when you try to download an app over 200 MB without a Wi-Fi connection from the App Store. We're working to reduce the size to be under this limit because it impacts downloads. So, we're addressing various areas and working with other third parties as well. Any reduction you can make in the size of your binaries would be greatly appreciated.

You can double check the total of strings using the strings command over firebase binaries and then have an idea about it. It doesn't mean that the total of the strings on it is the total of strings leaked, but then you can filter the list with some kinda list you provide about strings used in firebase binaries

[dconeybe]

That's an interesting motivation to reduce code size. I can see how that "warning" dialog could negatively impact download count.

We went through a similar exercise on the Firestore JS SDK, stripping out assertion messages to reduce code size. But that only reduced code size on the order of kilobytes. Again, my gut instinct is that even if we stripped out all messages it would save max 1 or 2 MB. That being said, it would need to be measured to know for sure.

I'll bring this up with the team and see if, and how, we want to proceed with this request.

[jesus-mg-ios]

Thanks for your effort @dconeybe it's much appreciated.