[Auth] Fix handling of AppCheck placeholder tokens #15555
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue where errors from AppCheck token retrieval were being ignored. Instead of continuing with a placeholder token, the code now properly propagates the error, which is a more robust and safer approach. The changes are well-implemented in both OAuthProvider and PhoneAuthProvider. The addition of new unit tests to cover these error scenarios is excellent, ensuring the fix is verified. I've added a couple of minor suggestions in the test files to improve maintainability.
| func testGetCredentialWithUIDelegateWithAppCheckError() throws { | ||
| let expectation = self.expectation(description: "App Check error propagated") | ||
| let fakeAppCheck = FakeAppCheck() | ||
| let expectedError = NSError(domain: "appCheckError", code: -1) |
There was a problem hiding this comment.
For improved maintainability and to avoid magic strings, consider defining "appCheckError" and -1 as private constants at the top of the OAuthProviderTests class. This would align with the existing practice for other test constants in this file.
|
|
||
| func testVerifyPhoneNumberWithAppCheckError() async throws { | ||
| let fakeAppCheck = FakeAppCheck() | ||
| let expectedError = NSError(domain: "appCheckError", code: -1) |
There was a problem hiding this comment.
For improved maintainability and to avoid magic strings, consider defining "appCheckError" and -1 as private constants at the top of the PhoneAuthProviderTests class. This makes the test code cleaner and easier to manage if these values are reused.
2 participants
Fix #15372