providerID should be nil in additionalUserInfo for signInAnonymouslyWithCompletion: #3452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collinjackson
changed the title
additionalUserInfo with signInAnonymouslyWithCompletion:.
collinjackson
changed the title
morganchen12
approved these changes
Jul 29, 2019
There was a problem hiding this comment.
LGTM, please wait for @renkelvin's approval before merging.
|
FYI @morganchen12 @renkelvin Only repo members can merge. I'll do this one. Thanks @collinjackson! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the behavior consistent between iOS and Android for
additionalUserInfoof an anonymous sign-in. Right now the iOS SDK is returning"password"(email sign-in) as theproviderIDbut I thinknilwould be more appropriate and matches Android.Also added a test.
Fixes #3450