Skip to content

providerID should be nil in additionalUserInfo for signInAnonymouslyWithCompletion: #3452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2019
Merged

providerID should be nil in additionalUserInfo for signInAnonymouslyWithCompletion: #3452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f611d3e
Testing for additionalUserInfo when signing in anonymously
collinjackson Jul 28, 2019
52d8d2a
Fix up test
collinjackson Jul 28, 2019
652182c
Fix behavior to match test
collinjackson Jul 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Example/Auth/Tests/FIRAuthTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1468,6 +1468,12 @@ - (void)testSignInAnonymouslySuccess {
XCTAssertTrue([NSThread isMainThread]);
[self assertUserAnonymous:result.user];
XCTAssertNil(error);
FIRAdditionalUserInfo *userInfo = result.additionalUserInfo;
XCTAssertNotNil(userInfo);
XCTAssertTrue(userInfo.isNewUser);
XCTAssertNil(userInfo.username);
XCTAssertNil(userInfo.profile);
XCTAssertNil(userInfo.providerID);
[expectation fulfill];
}];
[self waitForExpectationsWithTimeout:kExpectationTimeout handler:nil];
Expand Down
2 changes: 1 addition & 1 deletion Firebase/Auth/Source/Auth/FIRAuth.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,7 @@ - (void)signInAnonymouslyWithCompletion:(nullable FIRAuthDataResultCallback)comp
return;
}
FIRAdditionalUserInfo *additionalUserInfo =
[[FIRAdditionalUserInfo alloc] initWithProviderID:FIREmailAuthProviderID
[[FIRAdditionalUserInfo alloc] initWithProviderID:nil
profile:nil
username:nil
isNewUser:YES];
Expand Down