Skip to content

Conversation

@yifanyang
Copy link
Contributor

Most of our builds are pull request builds or feature branch builds, which are not for the purpose of release. Skipping the deployment stage in build process shorten these builds by a few minutes.

Copy link
Contributor

@jshcrowthe jshcrowthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jshcrowthe jshcrowthe merged commit 92aea91 into master Apr 13, 2018
@jshcrowthe jshcrowthe deleted the build-process branch April 13, 2018 23:26
jshcrowthe pushed a commit that referenced this pull request Apr 16, 2018
* Add build files/rules for all packages

* Remove old files

* Add builds for the top level firebase builds

* Adding scary DEBUG-MODE warning

* expose custom claims (#681)

* expose custom claims

* idtoken type declaration

* idtoken type declaration

* [AUTOMATED]: Prettier Code Styling

* style issue fix

* [AUTOMATED]: Prettier Code Styling

* add namesapce

* [AUTOMATED]: Prettier Code Styling

* Skip deployment if it is not master build in main repo. (#685)

* Firestore Node.js External Fix (#686)

* Reference the external Node 'util' lib

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: License Headers
jshcrowthe pushed a commit that referenced this pull request Apr 16, 2018
* Add build files/rules for all packages

* Remove old files

* Add builds for the top level firebase builds

* Adding scary DEBUG-MODE warning

* expose custom claims (#681)

* expose custom claims

* idtoken type declaration

* idtoken type declaration

* [AUTOMATED]: Prettier Code Styling

* style issue fix

* [AUTOMATED]: Prettier Code Styling

* add namesapce

* [AUTOMATED]: Prettier Code Styling

* Skip deployment if it is not master build in main repo. (#685)

* Firestore Node.js External Fix (#686)

* Reference the external Node 'util' lib

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: License Headers
jshcrowthe pushed a commit that referenced this pull request Apr 19, 2018
* Add build files/rules for all packages

* Remove old files

* Add builds for the top level firebase builds

* Adding scary DEBUG-MODE warning

* expose custom claims (#681)

* expose custom claims

* idtoken type declaration

* idtoken type declaration

* [AUTOMATED]: Prettier Code Styling

* style issue fix

* [AUTOMATED]: Prettier Code Styling

* add namesapce

* [AUTOMATED]: Prettier Code Styling

* Skip deployment if it is not master build in main repo. (#685)

* Firestore Node.js External Fix (#686)

* Reference the external Node 'util' lib

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: License Headers
jshcrowthe pushed a commit that referenced this pull request Apr 30, 2018
* Add build files/rules for all packages

* Remove old files

* Add builds for the top level firebase builds

* Adding scary DEBUG-MODE warning

* expose custom claims (#681)

* expose custom claims

* idtoken type declaration

* idtoken type declaration

* [AUTOMATED]: Prettier Code Styling

* style issue fix

* [AUTOMATED]: Prettier Code Styling

* add namesapce

* [AUTOMATED]: Prettier Code Styling

* Skip deployment if it is not master build in main repo. (#685)

* Firestore Node.js External Fix (#686)

* Reference the external Node 'util' lib

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: Prettier Code Styling

* [AUTOMATED]: License Headers
@firebase firebase locked and limited conversation to collaborators Oct 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants