Firestore Node.js External Fix #686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jshcrowthe
requested review from
mikelehen,
schmidt-sebastian and
wilhuff
as code owners
jshcrowthe
pushed a commit
that referenced
this pull request
Apr 16, 2018
* Add build files/rules for all packages * Remove old files * Add builds for the top level firebase builds * Adding scary DEBUG-MODE warning * expose custom claims (#681) * expose custom claims * idtoken type declaration * idtoken type declaration * [AUTOMATED]: Prettier Code Styling * style issue fix * [AUTOMATED]: Prettier Code Styling * add namesapce * [AUTOMATED]: Prettier Code Styling * Skip deployment if it is not master build in main repo. (#685) * Firestore Node.js External Fix (#686) * Reference the external Node 'util' lib * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers
jshcrowthe
pushed a commit
that referenced
this pull request
Apr 16, 2018
* Add build files/rules for all packages * Remove old files * Add builds for the top level firebase builds * Adding scary DEBUG-MODE warning * expose custom claims (#681) * expose custom claims * idtoken type declaration * idtoken type declaration * [AUTOMATED]: Prettier Code Styling * style issue fix * [AUTOMATED]: Prettier Code Styling * add namesapce * [AUTOMATED]: Prettier Code Styling * Skip deployment if it is not master build in main repo. (#685) * Firestore Node.js External Fix (#686) * Reference the external Node 'util' lib * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers
jshcrowthe
pushed a commit
that referenced
this pull request
Apr 19, 2018
* Add build files/rules for all packages * Remove old files * Add builds for the top level firebase builds * Adding scary DEBUG-MODE warning * expose custom claims (#681) * expose custom claims * idtoken type declaration * idtoken type declaration * [AUTOMATED]: Prettier Code Styling * style issue fix * [AUTOMATED]: Prettier Code Styling * add namesapce * [AUTOMATED]: Prettier Code Styling * Skip deployment if it is not master build in main repo. (#685) * Firestore Node.js External Fix (#686) * Reference the external Node 'util' lib * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers
jshcrowthe
pushed a commit
that referenced
this pull request
Apr 30, 2018
* Add build files/rules for all packages * Remove old files * Add builds for the top level firebase builds * Adding scary DEBUG-MODE warning * expose custom claims (#681) * expose custom claims * idtoken type declaration * idtoken type declaration * [AUTOMATED]: Prettier Code Styling * style issue fix * [AUTOMATED]: Prettier Code Styling * add namesapce * [AUTOMATED]: Prettier Code Styling * Skip deployment if it is not master build in main repo. (#685) * Firestore Node.js External Fix (#686) * Reference the external Node 'util' lib * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: Prettier Code Styling * [AUTOMATED]: License Headers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the build refactor the vast majority of imports worked seamlessly. However Firestore's import of the
utillib here (which translates to arequire('util')was not properly externally referenced resulting in errors.This correctly marks the lib as external for the Node.js build.