Skip to content

Fix functions deploy by upgrading to node 20 #9377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 13, 2025
Merged

Fix functions deploy by upgrading to node 20 #9377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3327532
Fix functions deploy by upgrading to node 20
hsubox76 Nov 12, 2025
836c36d
Update dep versions
hsubox76 Nov 12, 2025
32bfe18
Update deploy-if-needed script
hsubox76 Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
pushd functions
npm install
popd
npx firebase-tools@13.0.2 deploy --only functions:callTest --project jscore-sandbox-141b5 --token $FIREBASE_CLI_TOKEN
npx firebase-tools@14.24.2 deploy --only functions:callTest --project jscore-sandbox-141b5 --token $FIREBASE_CLI_TOKEN
working-directory: ./config
env:
FIREBASE_CLI_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}
Expand Down
2 changes: 1 addition & 1 deletion config/firebase.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
"indexes": "firestore.indexes.json"
},
"functions": {
"runtime": "nodejs18"
"runtime": "nodejs20"
}
}
2 changes: 1 addition & 1 deletion config/functions/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

const assert = require('assert');
const cors = require('cors')({ origin: true });
const functions = require('firebase-functions');
const functions = require('firebase-functions/v1');

/*
* These backend test helpers are copied from the iOS and Android SDKs, but are
Expand Down
2 changes: 1 addition & 1 deletion config/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"dependencies": {
"cors": "2.8.5",
"firebase-admin": "11.11.1",
"firebase-functions": "3.24.1"
"firebase-functions": "^7.0.0"
},
"private": true,
"engines": {
Expand Down
4 changes: 3 additions & 1 deletion scripts/ci-test/deploy-if-needed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ interface DeployOptions {
token: string;
cwd: string;
only?: string;
force: boolean;
}

/**
Expand Down Expand Up @@ -67,7 +68,8 @@ async function deployIfNeeded() {
const deployOptions: DeployOptions = {
project: config.projectId,
token,
cwd: resolve(root, 'config')
cwd: resolve(root, 'config'),
force: true
};
if (flags.length === 0) {
console.log(
Expand Down
Loading