Remove loggerProvider from public telemetry interface

[tonybaroneee]

As per API design review feedback.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 721ef71

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello @tonybaroneee, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a significant refinement to the public Telemetry interface by removing the loggerProvider property. This change, driven by API design review feedback, aims to encapsulate the loggerProvider as an internal implementation detail, thereby simplifying the external-facing API for consumers. The core logging functionality remains unchanged, but its direct exposure through the Telemetry interface has been eliminated, promoting a cleaner and more focused public contract.

Highlights

• API Interface Simplification: The loggerProvider property has been removed from the public Telemetry interface across all relevant API definitions (telemetry-angular.api.md, telemetry-react.api.md, telemetry.api.md, and public-types.ts).
• Documentation Updates: Corresponding documentation files (docs-devsite/telemetry_.telemetry.md, docs-devsite/telemetry_angular.telemetry.md, docs-devsite/telemetry_react.telemetry.md) have been updated to reflect the removal of loggerProvider from the public interface.
• Internal Access Adjustments: Internal code (api.ts, api.test.ts, helpers.ts, helpers.test.ts) has been updated with type assertions (e.g., (telemetry as TelemetryService).loggerProvider) to continue accessing the loggerProvider internally, ensuring its functionality remains intact while no longer being publicly exposed.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively removes the loggerProvider from the public Telemetry interface, improving encapsulation by hiding implementation details. The changes are consistent across the API definition files, documentation, and implementation. The use of type casting to TelemetryService in the implementation files to access the now-internal loggerProvider is appropriate.

My feedback focuses on the test files, where the type casting for mock objects could be made clearer to improve maintainability. Specifically, casting an object literal to a class type (TelemetryService) can be misleading.

[google-oss-bot]

Size Report ¹

Affected Products

No changes between base commit (572afb5) and merge commit (7762364).

Test Logs

• Base (572afb5): https://github.com/firebase/firebase-js-sdk/actions/runs/20038589193
• Merge (7762364): https://github.com/firebase/firebase-js-sdk/actions/runs/20049064324

1. https://storage.googleapis.com/firebase-sdk-metric-reports/fuaGaCAbbX.html

[google-oss-bot]

Size Analysis Report ¹

Affected Products

No changes between base commit (572afb5) and merge commit (7762364).

Test Logs

• Base (572afb5): https://github.com/firebase/firebase-js-sdk/actions/runs/20038589193
• Merge (7762364): https://github.com/firebase/firebase-js-sdk/actions/runs/20049064324

1. https://storage.googleapis.com/firebase-sdk-metric-reports/cZ54nKxuLW.html