Skip to content

Get tracing branch back to buildable state#9748

Merged
MaesterChestnut merged 1 commit intocrashlytics-tracingfrom
tracingFix
Mar 24, 2026
Merged

Get tracing branch back to buildable state#9748
MaesterChestnut merged 1 commit intocrashlytics-tracingfrom
tracingFix

Conversation

@MaesterChestnut
Copy link

No description provided.

@MaesterChestnut MaesterChestnut requested a review from rebehe March 24, 2026 13:39
@MaesterChestnut MaesterChestnut requested a review from a team as a code owner March 24, 2026 13:39
@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2026

⚠️ No Changeset found

Latest commit: de34d00

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses build stability by updating and aligning various package dependencies. The primary focus is on bringing Firebase SDKs to their latest patch versions and harmonizing OpenTelemetry library versions to resolve potential conflicts and ensure a consistent dependency graph across the project.

Highlights

  • Dependency Updates: Updated several Firebase SDK dependencies to their latest patch versions, including @firebase/component, @firebase/installations, @firebase/app, and @firebase/util.
  • OpenTelemetry Version Alignment: Synchronized OpenTelemetry dependencies across the project, specifically aligning @opentelemetry/api-logs, @opentelemetry/core, @opentelemetry/sdk-metrics, and @opentelemetry/sdk-trace-base to specific versions (e.g., 2.0.1 or 0.203.0). This involved both updates and some version downgrades to ensure consistency.
  • Yarn Lock File Cleanup: Cleaned up the yarn.lock file by removing outdated and no longer referenced OpenTelemetry package entries, reflecting the updated dependency tree.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@MaesterChestnut MaesterChestnut changed the title Build fix Get tracing branch back to buildable state Mar 24, 2026
@MaesterChestnut MaesterChestnut merged commit d59e7d8 into crashlytics-tracing Mar 24, 2026
15 of 19 checks passed
@MaesterChestnut MaesterChestnut deleted the tracingFix branch March 24, 2026 13:42
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several @firebase dependencies, presumably to fix a build issue. While the changes in packages/crashlytics/package.json are straightforward version bumps, the update to yarn.lock introduces some concerning changes. Specifically, several @opentelemetry/* packages are being downgraded, creating an inconsistency with the versions explicitly pinned in package.json. This could lead to unexpected behavior or regressions and makes dependency management more difficult. Please see my specific comment in yarn.lock for details and suggestions on how to address this.

Comment on lines +2796 to 2801
"@opentelemetry/api-logs@0.203.0":
version "0.203.0"
resolved "https://registry.npmjs.org/@opentelemetry/api-logs/-/api-logs-0.203.0.tgz#3309a76c51a848ea820cd7f00ee62daf36b06380"
integrity sha512-9B9RU0H7Ya1Dx/Rkyc4stuBZSGVQF27WigitInx2QQoj6KUpEFYPKoWjdFTunJYxmXmh17HeBvbMa1EhGyPmqQ==
dependencies:
"@opentelemetry/api" "^1.3.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This change in yarn.lock downgrades @opentelemetry/api-logs from 0.212.0 to 0.203.0. However, packages/crashlytics/package.json still specifies "@opentelemetry/api-logs": "0.212.0". This inconsistency can lead to confusion and unexpected behavior. Several other @opentelemetry packages are also being downgraded in this lock file as a side-effect of the @firebase dependency updates.

If these downgrades are intentional and necessary for the build fix, the package.json file should be updated to reflect these new, lower versions. This would make the intent clear and ensure consistent dependency resolution in the future.

If the downgrades are unintentional, the root cause should be investigated, as it might indicate a dependency conflict that needs to be resolved differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants