Skip to content

typescript utils and add some tests #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 7, 2018
Merged

typescript utils and add some tests #1003

merged 7 commits into from
Nov 7, 2018

Conversation

@bkendall
Copy link
Contributor

@bkendall bkendall commented Nov 7, 2018

Description

Typescripting src/utils and adding tests for them.

Scenarios Tested

firebase deploy with hosting, functions, and database.

@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Nov 7, 2018
@bkendall bkendall requested a review from mbleigh November 7, 2018 18:45
@coveralls
Copy link

Coverage Status

Coverage increased (+1.2%) to 57.953% when pulling e43617a on bk-utils-with-tests into 16c5114 on master.

@coveralls
Copy link

coveralls commented Nov 7, 2018 •
edited
Loading

Coverage Status

Coverage increased (+1.3%) to 57.983% when pulling 3befb1c on bk-utils-with-tests into 3d281d9 on master.

mbleigh
mbleigh approved these changes Nov 7, 2018
View reviewed changes
@mbleigh mbleigh assigned bkendall and unassigned mbleigh Nov 7, 2018
@bkendall bkendall merged commit d8e0072 into master Nov 7, 2018
@bkendall bkendall deleted the bk-utils-with-tests branch November 7, 2018 22:53
@snyk-bot snyk-bot mentioned this pull request Dec 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbleigh mbleigh mbleigh approved these changes

+1 more reviewer

@laurenzlong laurenzlong laurenzlong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bkendall bkendall

Labels

cla: yes Manual indication that this has passed CLA.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bkendall @coveralls @mbleigh @laurenzlong @googlebot