Dont fail listTools on billingInfo check

[joehan]

Description

Addresses b/492209700

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the Firebase MCP server by implementing a more resilient approach to checking project billing status. By wrapping the billing check in a safe, error-handling method, the system can now prevent critical functionalities like listing tools, prompts, and resources from failing if the billing information retrieval encounters an issue. This change improves the overall stability and user experience by ensuring that the application continues to function even when external dependencies might be temporarily unavailable or return errors.

Highlights

• Error Handling for Billing Checks: Introduced a new private method, safeCheckBillingEnabled, to gracefully handle errors that may occur when checking if billing is enabled for a project. This prevents the listTools functionality from failing due to transient issues with the billing check.
• Refactored Billing Check Calls: Replaced all direct calls to the checkBillingEnabled function within the FirebaseMcpServer class with calls to the newly created this.safeCheckBillingEnabled method, ensuring consistent error handling.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/mcp/index.ts
  • Replaced direct calls to checkBillingEnabled with this.safeCheckBillingEnabled in multiple locations.
  • Added a new private asynchronous method safeCheckBillingEnabled to wrap the checkBillingEnabled call in a try-catch block, logging errors and returning false on failure.

Activity

• No activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a safeCheckBillingEnabled method to prevent failures when checking for billing information, which is a good improvement. The new method gracefully handles errors by logging them and assuming billing is not enabled. I've suggested a small refinement in the new method to improve type safety and code readability, in line with the repository's best practices.

[gemini-code-assist]

The style guide recommends against using any as an escape hatch. Using unknown for the caught error with a type check is safer and aligns with modern TypeScript practices.

Additionally, using template literals for string formatting improves readability compared to concatenation.

Here's a suggestion that applies both improvements.

    } catch (e: unknown) {
      const message = e instanceof Error ? e.message : String(e);
      this.logger.debug(
        `[mcp] Error on billingInfo for ${projectId}, failing open (assuming false): ${message}`,
      );
      return false;
    }

References

1. The use of any in a catch block is an escape hatch. The style guide requires using proper types or type guards instead. ^(link)