Improve error message when test dir is not found

[lfkellogg]

Also makes the command help a little more informative, and cleans up some inconsistent capitalization.

Before:

firebase apptesting:execute \
  --app 1:12345:android:deadbeef \
   build/app/outputs/apk/release/app-release.apk

Error: Directory not found: tests

After:

$ firebase apptesting:execute \
  --app 1:12345:android:deadbeef \
   build/app/outputs/apk/release/app-release.apk

Error: Tests directory not found: /Users/username/dev/myapp/tests. Use the --test-dir flag to choose a different directory.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the user experience for the apptesting:execute command by providing more informative and actionable error messages when the designated test directory cannot be found. Instead of a generic 'Directory not found' error, users will now receive a detailed message that includes the full path of the missing directory and a clear suggestion on how to correct the issue, thereby streamlining the debugging process.

Highlights

• Improved Error Handling: Implemented a check to verify the existence of the specified or default test directory before proceeding with test execution.
• Enhanced User Feedback: Updated the error message for a missing test directory to be more descriptive, including the resolved path and suggesting the use of the --test-dir flag.
• Documentation Clarity: Clarified the default value for the --test-dir option in its description and standardized capitalization for several option descriptions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/commands/apptesting.ts
  • Imported dirExistsSync from ../fsutils and path module.
  • Added a directory existence check using dirExistsSync for the testDir option.
  • Introduced a FirebaseError with a more descriptive message if the test directory is not found, including the resolved path and a hint to use --test-dir.
  • Updated the help text for the --test-dir option to specify its default value.
  • Capitalized the first word of several option descriptions for consistency.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves the error message when the test directory is not found by providing the absolute path and a hint on how to specify a different directory. The implementation is correct and enhances the user experience. I've added one suggestion to improve code maintainability by narrowing the scope of a variable.