Fix permissions issue when deploying functions with latest Docekr image

[joehan]

Description

Fixes #10053 (I'm pretty sure, at least). Otherwise, the added logging will let us know the real issue.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical deployment issue by correcting file permissions within the Firebase Docker image, which was likely causing failures when deploying functions. Additionally, it enhances the diagnostic capabilities by improving error messages related to source directory access, providing more context for troubleshooting future deployment problems.

Highlights

• Docker Image Permissions: Added a chmod command to the Dockerfile to ensure correct file permissions (755) for Node.js packages and modules, addressing potential deployment issues.
• Enhanced Error Logging: Updated error messages in util.ts and prepareFunctionsUpload.ts to include the original error details when a source directory cannot be read, aiding in debugging.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• scripts/publish/firebase-docker-image/Dockerfile
  • Added a RUN chmod -R 755 /usr/local/node_packages /usr/local/lib/node_modules command to set appropriate permissions.
• src/deploy/apphosting/util.ts
  • Modified the FirebaseError message to include the Original: ${err} for better debugging when the source directory cannot be read.
• src/deploy/functions/prepareFunctionsUpload.ts
  • Modified the FirebaseError message to include the Original: ${err} for better debugging when the source directory cannot be read.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix a permissions issue in the Docker image and improve error logging. The changes to error messages in TypeScript files are good for debuggability. My feedback focuses on the Dockerfile change, where I've suggested a more precise and secure method for setting file permissions.