Skip to content

Only attempt to parse tests from yaml files#10111

Merged
kaibolay merged 4 commits intomainfrom
lk/onlyyaml
Mar 17, 2026
Merged

Only attempt to parse tests from yaml files#10111
kaibolay merged 4 commits intomainfrom
lk/onlyyaml

Conversation

@lfkellogg
Copy link
Contributor

@lfkellogg lfkellogg commented Mar 16, 2026

Previously it would attempt to parse any file under the --test-dir, resulting in some gnarly errors when parsing binary files.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the application's test parsing mechanism by introducing a file extension check. Previously, the system would attempt to parse any file found in a test directory as a potential test. With this change, the parsing process is now more targeted, focusing solely on files explicitly identified as YAML, which improves efficiency and prevents errors from attempting to parse non-test files.

Highlights

  • Test File Parsing: Modified the test file parsing logic to exclusively process files with a .yaml extension, ensuring only intended test definition files are considered.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/apptesting/parseTestFiles.ts
    • Added a condition to check if a file ends with .yaml before attempting to parse it as a test file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly restricts test file parsing to only YAML files by checking for the .yaml extension. My review includes a suggestion to also check for the .yml extension, as it is another common convention for YAML files, which would make this change more robust.

@lfkellogg lfkellogg force-pushed the lk/onlyyaml branch 2 times, most recently from 697d35f to 05e0b89 Compare March 16, 2026 20:43
@lfkellogg lfkellogg requested a review from kaibolay March 16, 2026 20:43
@kaibolay kaibolay enabled auto-merge (squash) March 16, 2026 21:52
@kaibolay kaibolay merged commit 2e02bf6 into main Mar 17, 2026
47 checks passed
@kaibolay kaibolay deleted the lk/onlyyaml branch March 17, 2026 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants