Write MCP debug logs to ~/.cache/firebase#10175
Conversation
When the Firebase MCP server starts, it calls useFileLogger() which writes firebase-debug.log to process.cwd(). This pollutes the user's project directory with an unrelated file, especially in projects that have no Firebase configuration. Write the MCP debug log to ~/.firebase/firebase-debug.log instead, creating the directory if needed. This matches the pattern of other Firebase tooling that uses ~/.firebase/ as a home for non-project data. Fixes #9982
Address code review feedback: use fs/promises mkdir with await instead of the synchronous mkdirSync, since mcp() is already async. This avoids blocking the event loop.
…-pollution # Conflicts: # CHANGELOG.md # src/bin/mcp.ts
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the logging mechanism for the MCP server to improve user experience and maintain a cleaner project structure. By redirecting debug logs to a standardized cache directory, it ensures that project folders remain free of transient log files, making debugging information more consistently located and less intrusive. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request moves the MCP server's firebase-debug.log file to a cache directory to avoid polluting the user's project directory. The current implementation places the log file in ~/.cache/firebase. A review comment suggests improving this by using platform-specific cache directories (e.g., %LOCALAPPDATA% on Windows, ~/Library/Caches on macOS) for better cross-platform adherence, and encapsulating this logic in a helper function as per the repository's style guide.
4 participants
Description
Slight twist on #9998 - thanks @VishnuVardanBR for the original change.
Fixes #9982.