Skip to content

Revert "Rename 'functionsrunapionly' experiment 'dartfunctions'."#10292

Merged
wandamora merged 1 commit intomainfrom
revert-10269-ajperel-rename-experiment
Apr 8, 2026
Merged

Revert "Rename 'functionsrunapionly' experiment 'dartfunctions'."#10292
wandamora merged 1 commit intomainfrom
revert-10269-ajperel-rename-experiment

Conversation

@wandamora
Copy link
Copy Markdown
Contributor

Reverts #10269

@wandamora wandamora linked an issue Apr 8, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the dartfunctions experiment to functionsrunapionly across the codebase, including deployment logic and tests. A review comment points out that the updated experiment description is incomplete, as the flag still gates Dart function support in several files, and suggests restoring that part of the description.

Comment thread src/experiments.ts
@wandamora wandamora requested a review from ajperel April 8, 2026 21:33
@wandamora wandamora merged commit af20c4e into main Apr 8, 2026
47 checks passed
@wandamora wandamora deleted the revert-10269-ajperel-rename-experiment branch April 8, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

functions deployment gets stuck when functionsrunapionly is enabled

3 participants