feat: add warnings when using experimental triggers in Dart runtime#10332
feat: add warnings when using experimental triggers in Dart runtime#10332Lyokone wants to merge 2 commits intofirebase:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a centralized classification system for Dart function triggers, categorizing them into production, emulator-only, and experimental support levels. It integrates warning logs into both the deployment preparation process and the functions emulator to inform users about limited trigger support. The review feedback suggests enhancing the detection and labeling of Eventarc triggers by explicitly checking for the presence of a channel and updating the service mapping logic to include Eventarc explicitly.
ajperel
left a comment
ajperel
left a comment
There was a problem hiding this comment.
This LGTM but let me see if I can get a more experienced developer of firebase-tools to take a look.
| * Only non-production endpoints are returned — callers never need to | ||
| * enumerate production-ready functions. | ||
| */ | ||
| export function classifyEndpoints(endpoints: backend.Endpoint[]): { |
There was a problem hiding this comment.
Nit: Naming is a bit unclear here, since it only classifies non-production endpoints. Maybe rename to classifyNonProductionEndpoints
joehan
left a comment
joehan
left a comment
There was a problem hiding this comment.
LGTM, please add a CHANGELOG entry like:
- Improved warning messages when deploying or emulating Dart functions.
|
Can be abandoned as I merged #10338 |
kevmoo
left a comment
kevmoo
left a comment
There was a problem hiding this comment.
Abandon this. We have the fix in already!
5 participants
Description
Adding warnings when using experimental triggers in Dart runtime.
Fixes #10305
Scenarios Tested
running
emulator:startanddeployYou can see the warning here for firestore triggers.