Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Firebase Data Connect local toolkit to version 3.4.7, including updates to the changelog and emulator download metadata. Feedback was provided regarding a likely incorrect expectedSize for the Linux emulator and suggestions to improve the consistency and formatting of the changelog entries.
I am having trouble creating individual review comments. Click here to see my feedback.
src/emulator/downloadableEmulatorInfo.json (81)
The expectedSize for the Linux emulator (line 82) was not updated, remaining identical to the version 3.4.6 value, while the version, checksums, and remote URL were all updated. Given that the binary size changed for all other platforms (Darwin, Darwin ARM64, and Windows), it is highly probable that the Linux binary size has also changed. An incorrect expectedSize will cause download verification to fail for Linux users.
CHANGELOG.md (3-5)
For better consistency with existing entries, consider using the past tense ("Fixed", "Added") for the descriptions. Additionally, it is recommended to use backticks for code symbols like uuidv4(), _Data, and @allow to improve readability in the rendered changelog.
- Fixed emulator crash when using uuidv4() on operations.
- Added support for _Data input types as operation variables, enabling batch mutations.
- Added the @allow directive on variable definitions to restrict fields and max item counts for _Data variables.
- Fix emulator crash when using `uuidv4()` on operations. - Support for `_Data` input types as operation variables, enabling batch mutations. - The `@allow` directive on variable definitions to restrict fields and max item counts for `_Data` variables.
436c493 to
f49521e
Compare
Description
Scenarios Tested
Sample Commands