Don't use ProgressBar when non-interactive. #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/deploy/hosting/deploy.js
Outdated
There was a problem hiding this comment.
I'm not sure this logic is correct. In the case where !process.stderr is true, we don't want to use the ProgressBar module since it may throw (as we have seen). I think the logic we want is if (process.stderr && !options.nonInteractive).
|
One comment on the logic for when to switch from the progress bar to the dots. Otherwise, looks good. Back to you. |
Contributor
Author
|
@jwngr think I fixed the logic. Can you try my branch locally just for a second set of hands-on before merging? |
jwngr
pushed a commit
that referenced
this pull request
Oct 15, 2015
Don't use ProgressBar when non-interactive.
|
I tried this out locally and it worked great! Let's ship it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead, print out 100 dots for each percent to stdout.