Skip to content

Fix vscode webpack build #7509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Fix vscode webpack build #7509

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6305a7e
fix webpack build
hlshen Jul 30, 2024
becc66f
Merge branch 'master' into hlshen/fixvscode
hlshen Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions firebase-vscode/webpack.common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,8 @@ const extensionConfig = {
// support reading TypeScript and JavaScript files, 📖 -> https://github.com/TypeStrong/ts-loader
// mainFields: ['browser', 'module', 'main'], // look for `browser` entry point in imported node modules
mainFields: ["main", "module"],
extensions: [".ts", ".js"],
extensions: [".ts", ".js", ".json"], // needed to handle a node_module dependency emojilib, which requires json without ext.
alias: {
// provides alternate implementation for node module and source files
"marked-terminal": path.resolve(__dirname, "src/stubs/empty-class.js"),
// "ora": path.resolve(__dirname, 'src/stubs/empty-function.js'),
commander: path.resolve(__dirname, "src/stubs/empty-class.js"),
inquirer: path.resolve(__dirname, "src/stubs/inquirer-stub.js"),
Expand All @@ -87,7 +85,6 @@ const extensionConfig = {
// This is used for Github deploy to hosting - will need to restore
// or find another solution if we add that feature.
"libsodium-wrappers": path.resolve(__dirname, "src/stubs/empty-class.js"),
marked: path.resolve(__dirname, "src/stubs/marked.js"),
},
fallback: {
// Webpack 5 no longer polyfills Node.js core modules automatically.
Expand Down