Skip to content

Conversation

@TomasMorton
Copy link
Member

@TomasMorton TomasMorton commented Jul 30, 2024

Description

Adds support for using -k to specify --kms-key-name when creating a firestore database. This aligns with #7483.

Scenarios Tested

  • No key provided
  • Key provided with -k
  • Key provided with --kms-key-name

Sample Commands

  • firebase firestore:databases:create database --location nam5 -k key
  • firebase firestore:databases:create database --location nam5 --kms-key-name key
  • firebase firestore:databases:create database --location nam5

@TomasMorton TomasMorton force-pushed the tm-firestore-create-db-kms-key-name-short branch from 8f1737c to 48603a9 Compare July 30, 2024 20:18
@TomasMorton TomasMorton marked this pull request as ready for review July 30, 2024 20:18
@TomasMorton TomasMorton requested a review from jinyangtang July 30, 2024 20:18
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.39%. Comparing base (3ed5803) to head (48603a9).
Report is 33 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7510      +/-   ##
==========================================
- Coverage   53.85%   53.39%   -0.47%     
==========================================
  Files         388      390       +2     
  Lines       26326    26733     +407     
  Branches     5416     5505      +89     
==========================================
+ Hits        14178    14273      +95     
- Misses      10877    11187     +310     
- Partials     1271     1273       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jinyangtang jinyangtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the shortcut.

@joehan joehan merged commit 69a815c into master Aug 1, 2024
@joehan joehan deleted the tm-firestore-create-db-kms-key-name-short branch August 1, 2024 21:37
@TomasMorton
Copy link
Member Author

Thanks for updating and merging @joehan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants